Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 浮点数精度丢失导致画布缩放卡死 #4356

Merged
merged 2 commits into from
Jul 8, 2024
Merged

fix: 浮点数精度丢失导致画布缩放卡死 #4356

merged 2 commits into from
Jul 8, 2024

Conversation

ch1ny
Copy link
Contributor

@ch1ny ch1ny commented Jul 7, 2024

Description

在 mousewheel 计算下一个缩放尺寸时，会因为js浮点数计算问题导致缩放尺寸计算存在误差：

  • 即在缩小画布时，会计算出增大画布的缩放比例；
  • 在放大画布时，会计算出缩小画布的缩放比例

Motivation and Context

在某些特定情况下，会导致画布的缩放比例被卡在某两个值之间来回切换，导致画布无法进行缩放。

#4168

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@x6-bot
Copy link
Contributor

x6-bot bot commented Jul 7, 2024

👋 @ch1ny

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add graph.scale() method
  • docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

  • Follow the TypeScript, JavaScript, CSS and React coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@x6-bot x6-bot bot added PR: unreviewed PR does not have any reviews. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. pkg:x6 labels Jul 7, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 10.34%. Comparing base (a431f52) to head (5d118d6).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4356   +/-   ##
=======================================
  Coverage   10.34%   10.34%           
=======================================
  Files         180      180           
  Lines       10582    10582           
  Branches     2580     2580           
=======================================
  Hits         1095     1095           
  Misses       9398     9398           
  Partials       89       89
Flag Coverage Δ
x6 10.34% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/x6/src/graph/mousewheel.ts 7.27% <0.00%> (ø)

@x6-bot x6-bot bot added PR: reviewed-approved PR has reviewed and got Approve from everyone. and removed PR: unreviewed PR does not have any reviews. labels Jul 8, 2024
@NewByVector NewByVector merged commit 78179da into antvis:master Jul 8, 2024
9 checks passed
@x6-bot
Copy link
Contributor

x6-bot bot commented Jul 8, 2024

👋 @ch1ny

Congrats on merging your first pull request! 🎉🎉🎉

@x6-bot x6-bot bot added PR: merged PR has merged. and removed PR: reviewed-approved PR has reviewed and got Approve from everyone. labels Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NewByVector NewByVector NewByVector approved these changes

Assignees
No one assigned
Labels
pkg:x6 PR: merged PR has merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ch1ny @codecov-commenter @NewByVector